[8011944] Sort fails with ArrayIndexOutOfBoundsException

[Paul Sandoz]

On Jan 23, 2014, at 11:55 PM, Miroslaw Niemiec <miroslaw.niemiec at oracle.com> wrote:

> Hello!
> 
> This is a simple backport from 8 to 7.

Looks good to me (as Florian points out the test requires a license and updates to dates on those source files).


> Looking for a review of this even though it only requires a testcase change due to the use of lambda expressions.
> Since this is the first of these I've encountered I thought I better play it safe, but generally speaking, are we ok
> to skip the review process for backports like this? (minor lambda related testcase changes - if the lambda's are in the actual fix it probably makes sense to re-review).
> 

I am not entirely sure of the process but here are my thoughts:

- if the patch applies/compiles/runs/tests cleanly on a previous release then there is probably no need for a review in most cases.

- if the patch requires explicit merging or updates then a review is probably required.

Sometimes a patch could be contextual and have some implicit (and not direct) dependency on something else not in the patch, so i think we have to exercise our judgment on a per-patch basis.

Paul.