RFR for JDK-8028711: TEST_BUG: Tests should pass through VM options: corelibs tests

[Alan Bateman]

On 26/01/2014 08:10, michael cui wrote:
> Hi,
>
> Please review the following code changes for
>
> https://bugs.openjdk.java.net/browse/JDK-8028711
>
> The bug and fix are for enforcing the following rules:
>
> launch java from shell script, ${TESTVMOPTS} and ${TESTJAVAOPTS} 
> should be passed in.
> launch javac from shell script, ${TESTTOOLVMOPTS} and ${TESTJAVACOPTS} 
> should be passed in.
>
> So almost all the scripts who failed to follow above rules are touched 
> by this fix.
>
> There are very few exceptions since test cases explicitly state that 
> they are intended to launch java without any vm options.
>
>
> webrev
> http://cr.openjdk.java.net/~tyan/michael/JDK-8028711/webrev.01/
You might be aware of this area but we've had two previous efforts ([1] 
[2]) to update these tests to pass through options. I have to admit that 
I wasn't aware of TESTJAVAOPTS or TESTJAVACOPTS. Looking at the" jtreg 
-help all" page then these seem to correspond to -javaoption and 
-javacoption. I see -vmoption used all the time to specify options, I 
don't think I've seen -javaoption being used but I see your point. One 
thing that might be helpful here is some guidance or examples as it 
confusing to have so many options that initially appear to do the same 
thing.

Mike Duigou might want to have a quick look to see if jdk/Makefile needs 
to be updated to support -javacoption. As these tests aren't really 
testing javac (except incidentally) then it might not be important but 
it's yet another place where you can loose a finger.

I haven't looked at all the files but just notice that you've updated 
the genXXX scripts. They are used to generate tests, they aren't tests 
themselves and so aren't run by jtreg.

So are you planning to also update the java tests that create VMs to 
pass through the options? This point came up during previous efforts 
(and some test infrastructure has been added) but it isn't clear to me 
where we are on that.

-Alan.

[1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae5d04dbacd6
[2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7da291690aa0