RFR [9] 8011645: CopyOnWriteArrayList.COWSubList.subList does not validate range properly

[Chris Hegarty]

Thanks I’ll update the test before pushing.

I know you have tests in the TCK for this now, but I’ll add the trivial jtreg test to OpenJDK to ensure this doesn’t creep back.

-Chris.

On 31 Jan 2014, at 18:07, Martin Buchholz <martinrb at google.com> wrote:

> The jtreg test is fine, but:
> 
> s/IOBE/IOOBE/
> 
> When I created MOAT.java many years ago, I intended tests such as this to get added to that, so that all of the List implementations could share the same test code.  jsr166 does not have the same concern, since it only has one List implementation at the moment.  Today, there are other choices, like sharing test infrastructure with Guava e.g. ListTestSuiteBuilder.  More generally, openjdk core libraries can benefit from all the great testing work that guava folk have done.
> 
> 
> On Fri, Jan 31, 2014 at 8:23 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> Trivial change to CopyOnWriteArrayList.COWSubList.subList to catch the case where the fromIndex is greater that the toIndex.
> 
> http://cr.openjdk.java.net/~chegar/8011645/webrev.00/webrev/
> 
> -Chris.
>