RFR 8049220: URL.factory data race

Pavel Rappo pavel.rappo at oracle.com
Thu Jul 3 10:07:30 UTC 2014


Hi Peter,

Just a minor subjective issue. I would suggest changing the name of the local variable 'factory' in java.net.URL.getURLStreamHandler method for something different. It's a bit hard to read the code since this variable clashes with the same-name class field.

Thanks,
-Pavel

On 3 Jul 2014, at 09:43, Peter Levart <peter.levart at gmail.com> wrote:

> Hi,
> 
> I noticed a data race in java.net.URL:
> 
>    https://bugs.openjdk.java.net/browse/JDK-8049220
> 
> I propose the following simple patch:
> 
> http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.01/
> 
> 
> Regards, Peter




More information about the core-libs-dev mailing list