8049055: Tests added to the jdk/test/TEST.groups to be run on correct profiles

[Daniel Fuchs]

Hi Evgeniya,

This looks OK for java/util/logging/TestLoggingWithMainAppContext.java,
but by looking at javax/xml/ws/clientjar/TestWsImport.java I get
the impression that this tests depends on the jdk, rather
than on the JRE:

public class TestWsImport {

     public static void main(String[] args) throws IOException {

         String javaHome = System.getProperty("java.home");
         if (javaHome.endsWith("jre")) {
             javaHome = new File(javaHome).getParent();
         }
         String wsimport = javaHome + File.separator + "bin"
                                + File.separator + "wsimport";
     ...
}

So I wonder whether this one should be added to the needs_jdk
list instead?

best regards,

-- daniel



On 7/4/14 11:33 AM, Evgeniya Stepanova wrote:
> Re-attached lost diff
>
> Also, just for sure, diff as plain text (really small)
>
> diff -r fafb06b35f05 test/TEST.groups
> --- a/test/TEST.groups    Sun Jun 22 18:50:35 2014 -0400
> +++ b/test/TEST.groups    Thu Jul 03 16:23:05 2014 +0400
> @@ -369,7 +369,9 @@
>     javax/crypto/Cipher/CipherStreamClose.java \
>     javax/management/monitor/AttributeArbitraryDataTypeTest.java \
>     jdk/lambda/vm/InterfaceAccessFlagsTest.java \
> -  sun/misc/URLClassPath/ClassnameCharTest.java
> +  sun/misc/URLClassPath/ClassnameCharTest.java \
> +  java/util/logging/TestLoggingWithMainAppContext.java \
> +  javax/xml/ws/clientjar/TestWsImport.java
>
>   # Tests dependent on the optional charsets.jar
>   # These are isolated for easy exclusions
>
> On 04.07.2014 11:37, Evgeniya Stepanova wrote:
>> Hi all
>>
>> Could you please review fix for 8049055
>>
>> Problem:
>> java/util/logging/TestLoggingWithMainAppContext.java is designed to
>> use awt,which is in full jre
>> javax/xml/ws/clientjar/TestWsImport.java tests API that is only in
>> full jre
>> Tests were running on compacts and failed.
>> Solution:
>> Both tests are added to the needs_jre test group in jdk/test/TEST.groups
>> Testing:
>> locally,tests excluded as expected
>>
>> In attachements diff against 8udev repo
>>
>> Thank you.
>> Evgeniya Stepanova
>