RFR: [6904367]: (coll) IdentityHashMap is resized before exceeding the expected maximum size

Martin Buchholz martinrb at google.com
Tue Jul 8 07:33:49 UTC 2014


I've updated the webrev
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/IdentityHashMap-capacity/
It now has all my TODOs done.
The test case has been testng-ified.

On Mon, Jul 7, 2014 at 6:54 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com>
wrote:

>
> Unfortunately, x + x << 1 causes the same overflow bug as 3*x:
>

x + (x << 1) is merely supposed to be possibly more efficient than 3*x.


> (int)(1431655766 + 1431655766 << 1) == 2
>

OK, I think my latest version doesn't have any overflow bugs.



More information about the core-libs-dev mailing list