Review request for 8050804: (jdeps) Recommend supported API to replace use of JDK internal API

Mandy Chung mandy.chung at oracle.com
Thu Jul 17 14:43:39 UTC 2014


On 7/17/2014 2:41 AM, Daniel Fuchs wrote:
> Hi Mandy,
>
> minor:
> JdepsTask.java:977 could be refactored to use putIfAbsent
>

ok.

> I wonder whether the summary table at the end should contain a warning
> for all the usage of jdk internals that have no replacement?
>

It's intentional.  The list shown by jdeps is not an excessive list and only
includes the classes that I found are used in several products. When we find
more jDK internal APIs that are used and have a replacement (or RFE), I'll
update the wiki.

> Otherwise looks good! I like the output much better :-)
>

Thanks
Mandy

> best regards,
>
> -- daniel
>
> On 7/17/14 12:38 AM, Mandy Chung wrote:
>> Updated webrev:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8050804/webrev.01/
>>
>> I plan to backport this to 8u40.
>>
>> Mandy
>>
>> On 7/16/14 8:09 AM, Mandy Chung wrote:
>>> My first version prints a separate table of the replacements following
>>> the new warning message at the end of the jdeps output. I like the
>>> first version better than this version replacing rt.jar with "Use..."
>>> message.   I might be too anxious getting developers to take action
>>> using the supported APIs when there is one and hence this version.
>>>
>>> I'll update the webrev to print as a separate table.
>>>
>>> thanks
>>> Mandy
>>>
>>> On 7/16/2014 6:10 AM, Daniel Fuchs wrote:
>>>> Hi Mandy,
>>>>
>>>> here is a typical output - with names mangled to save
>>>> space:
>>>>
>>>> s.u.l.p.LPA (rt.jar)
>>>>   -> s.s.a.GP       JDK internal API (Use j.s.PA @since 1.1)
>>>>   -> s.u.c.CLDRLPA  JDK internal API (rt.jar)
>>>>
>>>> In the first dependency line, the archive name has been replaced
>>>> by the 'Use ...' message.
>>>>
>>>> I wonder whether it would be better to keep the archive name
>>>> and print the use message as additional information, in order
>>>> to be 'script friendly' so that you could use things like
>>>> | grep 'rt.jar' on the output.
>>>>
>>>> best regards,
>>>>
>>>> -- daniel
>>>>
>>>> On 7/16/14 1:35 AM, Mandy Chung wrote:
>>>>> jdeps -jdkinternals flags use of JDK internal APIs.  We have 
>>>>> created a
>>>>> wiki page to keep track of the JDK internal APIs and its replacement:
>>>>> https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool 
>>>>>
>>>>>
>>>>>
>>>>> While this page will be updated when we identify any new ones
>>>>> worthnoting, it'd still be useful for jdeps to suggest the 
>>>>> replacement
>>>>> APIs of the known ones.
>>>>>
>>>>> webrev at:
>>>>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8050804/webrev.00/
>>>>>
>>>>> Mandy
>>>>
>>>
>>
>




More information about the core-libs-dev mailing list