RFR [8051382] Optimize java.lang.reflect.Modifier.toString()

Ivan Gerasimov ivan.gerasimov at oracle.com
Fri Jul 18 22:57:04 UTC 2014


In the test I only replaced

import java.lang.reflect.*;

with

import java.lang.reflect.Modifier;

and added the new bugid to the @bug tag.

Sincerely yours,
Ivan

On 19.07.2014 2:53, Martin Buchholz wrote:
> It looks like the test has a new import, but no actual new code that 
> uses it.
>
>
> On Fri, Jul 18, 2014 at 3:39 PM, Ivan Gerasimov 
> <ivan.gerasimov at oracle.com <mailto:ivan.gerasimov at oracle.com>> wrote:
>
>     Hello!
>
>     StringBuilder can be replaced with StringJoiner, which will make
>     the code shorter and, probably, more efficient.
>     The existing regtest
>     (java/lang/reflect/Modifier/toStringTest.java) can be used to make
>     sure nothing is broken.
>
>     Would you please help review the fix?
>
>     BUGURL: https://bugs.openjdk.java.net/browse/JDK-8051382
>     WEBREV: http://cr.openjdk.java.net/~igerasim/8051382/0/webrev/
>     <http://cr.openjdk.java.net/%7Eigerasim/8051382/0/webrev/>
>
>     Sincerely yours,
>     Ivan
>
>




More information about the core-libs-dev mailing list