RFR [9] 8006627: UUID to/from String performance should be improved by reducing object allocations

Claes Redestad claes.redestad at oracle.com
Mon Jul 21 11:41:47 UTC 2014


On 07/19/2014 02:59 PM, Ivan Gerasimov wrote:
> This looks just beautiful!

Thanks!

> But why do you need the digits() function at all?
> In my opinion, using formatUnsignedLong directly would be no less 
> clearer.

Sure!

http://cr.openjdk.java.net/~redestad/8006627/webrev.2/

Small improvement with client compiler; no measurable change with tiered.

/Claes

>
> Sincerely yours,
> Ivan
>
> On 19.07.2014 8:59, Claes Redestad wrote:
>> Hi,
>>
>>  after recent changes, this patch has been revisited and improved 
>> slightly, primarily simplifying and speeding up the toString method 
>> slightly more:
>>
>>  http://cr.openjdk.java.net/~redestad/8006627/webrev.1/
>>
>>  /Claes
>>
>> On 2014-06-15 00:41, Claes Redestad wrote:
>>> Hi,
>>>
>>> please review this patch to improve UUID performance, originally 
>>> proposed by Steven Schlansker, rebased to use the allocation-free 
>>> methods added in https://bugs.openjdk.java.net/browse/JDK-8041972
>>>
>>> Webrev: http://cr.openjdk.java.net/~redestad/8006627/webrev.0/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8006627
>>>
>>> Thanks!
>>>
>>> /Claes
>>
>>
>>
>




More information about the core-libs-dev mailing list