RFR (XS) JDK-8051861 [TESTBUG] test "java/math/BigInteger/BigIntegerTest.java" does not hold Random value to have a possibility to reproduce it

vasily stolbov vasily.stolbov at oracle.com
Fri Jul 25 15:22:59 UTC 2014


Hi!

Fixed.

On 24.07.2014 19:52, Joe Darcy wrote:
>
> If you are going to report the seed to the test log, that should be 
> done unconditionally regardless of whether a passed in seed is being 
> used. 

-------------- next part --------------
diff -r 08d0c4b1a48d test/java/math/BigInteger/BigIntegerTest.java
--- a/test/java/math/BigInteger/BigIntegerTest.java	Wed Jul 02 10:03:40 2014 +0100
+++ b/test/java/math/BigInteger/BigIntegerTest.java	Fri Jul 25 19:22:05 2014 +0400
@@ -34,6 +34,8 @@
 import java.io.FileOutputStream;
 import java.io.ObjectInputStream;
 import java.io.ObjectOutputStream;
+import java.lang.Long;
+import java.lang.System;
 import java.math.BigInteger;
 import java.util.Random;
 
@@ -944,8 +946,23 @@
      *
      */
     public static void main(String[] args) throws Exception {
+      //reproducibility fix
+        String seed = System.getProperty("startseed");
+        if(seed!=null){
+            rnd.setSeed(Long.valueOf(seed).longValue());
+            System.err.println("Seed: " + seed);
+        }else{
+            Long currentSeed = rnd.nextLong();
+            System.err.println("Seed: " + currentSeed);
+            rnd.setSeed(currentSeed);
+        }
+
+
+
 
         // Some variables for sizing test numbers in bits
+
+
         int order1 = ORDER_MEDIUM;
         int order2 = ORDER_SMALL;
         int order3 = ORDER_KARATSUBA;


More information about the core-libs-dev mailing list