Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

[roger riggs]

Hi Eric,

A few comments:

  - TestBase.java: 39:  typo  "Unexcepted" -> "Unexpected"

  - TestUtils.java: 32:  Consider moving XML_DIR to TestBase.java, it 
seems similar to the other static final strings

  - TestBase.java: 57,66; Is the extra starting/ending output useful for 
TestNg Tests?
    TestNg should already print a test header

  - XPath<xxx>: note that TestNg will report any uncaught exception as a 
failure;
    it is not necessary to catch the exception and call fail().

  - XPathFunctionResolver01: Nice use of Lambda  :)

I realize these are ported tests and you may be keeping things as much 
as possible to the existing tests.

Thanks, Roger


On 7/25/2014 9:12 AM, Eric Wang wrote:
> Hi Joe, alan and every one
>
> I'm working on jaxp functional test colocation which is traced by the 
> bug JDK-8043091 <https://bugs.openjdk.java.net/browse/JDK-8043091>.
> We have finished to convert a few suite and the jaxp/xpath tracked by 
> bug JDK-8051561 <https://bugs.openjdk.java.net/browse/JDK-8051561> is 
> the first one chosen for public review.
>
> Can you please review the webrev below? your comments given would be 
> helpful for our future work.
> http://cr.openjdk.java.net/~ewang/JDK-8051561/webrev.00/
>
> Thanks,
> Eric
>