RFR (JAXP): 8041523:Xerces Update: Serializer improvements from Xalan

[David Li]

I just checked and it is removed in my browser.  I think you may need to 
clear your browser cache (or use a different browser). That's what I had 
to do before the changes would show up.

-David

On 6/4/2014 2:26 PM, huizhe wang wrote:
> The followings are still in the webrev:
>  - the unused AbstractTranslet: import java.util.Vector
>     can be removed
>
>  - comments in EmptySerializer and ToSAXHandler: 
> SerializationHandler#setCdataSectionElements(java.util.Vector)
>    The issue is SerializationHandler does not define a method 
> "setCdataSectionElements"
>
> -Joe
>
> On 6/4/2014 2:04 PM, David Li wrote:
>> Hi Joe,
>>
>> I have applied these changes and uploaded for review. 
>> http://cr.openjdk.java.net/~dli/8041523/webrev/.  Let me know if you 
>> see anything else.
>>
>> Thanks,
>> David
>>
>> On 6/4/2014 12:27 PM, huizhe wang wrote:
>>> Hi David,
>>>
>>> Good work!
>>>
>>> This is a major patch in Xalan, one last in Xalan 2.7.1. Previously, 
>>> it caused many failures in JCK and SQE regression tests. I see that 
>>> you've resolved those failures with the fix stated below, and 
>>> getting all tests to pass.
>>>
>>> Some minor cleanup may be desirable, such as:
>>>  - the unused AbstractTranslet: import java.util.Vector
>>>  - comments in EmptySerializer and ToSAXHandler: 
>>> SerializationHandler#setCdataSectionElements(java.util.Vector)
>>>  - comment in the new method initCdataElems in SerializerBase that 
>>> "we just ended a URI, add the URI to the vector" although it didn't.
>>>  - comments in ToStream about setCdataSectionElements(Vector v)
>>>
>>> Thanks,
>>> Joe
>>>
>>> On 6/4/2014 11:35 AM, David Li wrote:
>>>> Hi,
>>>>
>>>> This is an update to JAXP serialization from Apache Xalan. For 
>>>> details, please refer to: 
>>>> https://bugs.openjdk.java.net/browse/JDK-8041523.
>>>>
>>>> Webrevs: http://cr.openjdk.java.net/~dli/8041523/webrev/
>>>>
>>>> Summary of changes.
>>>> * Changes from the Apache bug referenced in JDK-8041523
>>>> * Update ToStream.setCdataSectionElements to a newer version from 
>>>> the most recent Apache ToStream.java source file.  This was causing 
>>>> the JCK test failures noted in the bug.  Note, there are two 
>>>> setCdataSectionElement methods in ToStream.java.  The one with the 
>>>> bug has been fixed.
>>>> * Some updates to accommodate ArrayList, HashMap, and Generics.
>>>> * Bundled in changes for JDK-8037259.  This was an xpointer bug.
>>>>
>>>> Existing tests: JAXP SQE and unit tests passed.  JCK tests passed.
>>>>
>>>> Thanks,
>>>> David
>>>
>>
>