Ready for Review : 8042469 : Launcher changes for native memory tracking scalability enhancement

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Jun 20 23:45:29 UTC 2014


Neil,

Generally looks good, yes JLI_* functions must be used, I missed that one.
Are you going to post another iteration ?

Kumar

On 6/20/2014 4:27 PM, Neil Toda wrote:
>
> Thanks Joe.  It would have checked for NULL for me.
> I'll use the JLI wrapper.
>
> -neil
>
> On 6/20/2014 4:04 PM, Joe Darcy wrote:
>> Memory allocation in the launcher should use one of the JLI_MemAlloc 
>> wrappers, if possible.
>>
>> -Joe
>>
>>
>> On 06/20/2014 09:50 AM, Neil Toda wrote:
>>>
>>> They should complain.  Thanks Zhengyu.  I'll make sure these are 
>>> non-null.
>>>
>>> -neil
>>>
>>> On 6/20/2014 5:01 AM, Zhengyu Gu wrote:
>>>> Neil,
>>>>
>>>> Thanks for quick implementation.
>>>>
>>>> java.c:
>>>>   Did not check return values of malloc(), I wonder if source code 
>>>> analyzers will complain.
>>>>
>>>> -Zhengyu
>>>>
>>>> On 6/19/2014 8:29 PM, Neil Toda wrote:
>>>>>
>>>>> Launcher support for modified Native Memory Tracking mechanism in 
>>>>> JVM in JDK9.
>>>>>
>>>>> Webrev  : http://cr.openjdk.java.net/~ntoda/8042469/webrev-03/
>>>>> bug         : https://bugs.openjdk.java.net/browse/JDK-8042469
>>>>> CCC         : http://ccc.us.oracle.com/8042469
>>>>>
>>>>> Thanks.
>>>>>
>>>>> -neil
>>>>>
>>>>
>>>
>>
>




More information about the core-libs-dev mailing list