Long valueOf instead of new Long

Andrej Golovnin andrej.golovnin at gmail.com
Mon Jun 30 10:31:08 UTC 2014


Hi Pavel,

http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/sun/reflect/UnsafeLongFieldAccessorImpl.java.sdiff.html
>
> http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/sun/reflect/UnsafeQualifiedLongFieldAccessorImpl.java.sdiff.html
>
> http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/sun/reflect/UnsafeQualifiedStaticLongFieldAccessorImpl.java.sdiff.html
>
> http://cr.openjdk.java.net/~prappo/8048267/webrev.03/src/share/classes/sun/reflect/UnsafeStaticLongFieldAccessorImpl.java.sdiff.html


Please don't change the UnsafeXXXFieldAccessorImpl classes.
This classes should be changed as a part of the fix of the issue 5043030.
The patch for this issue has been already submitted, see here:

http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-June/027311.html

When Joel is back, he will continue to work on it.

Otherwise it looks good to me.

Best regards,
Andrej Golovnin



More information about the core-libs-dev mailing list