RFR: 8047722: @since tag cleanup in corba
Henry Jen
henry.jen at oracle.com
Mon Jun 30 15:17:05 UTC 2014
On 06/30/2014 12:18 AM, Alan Bateman wrote:
> On 30/06/2014 02:30, Henry Jen wrote:
>> Ping.
>>
>> :
>>
>> On 06/20/2014 02:28 PM, Henry Jen wrote:
>>> Hi,
>>>
>>> Please review a trivial webrev for jdk9/corba that do the same @since
>>> tag normalization as in jdk9/jdk.
>>>
>>> http://cr.openjdk.java.net/~henryjen/jdk9/8047722/0/webrev/
> There are bunch of @since JDK 1.0 and JDK 1.1.6 that you are changing to
> 1.0 and 1.1.6. AFAIK, CORBA was added in 1.2 and I wonder if we should
> fix this as part of this change.
>
Thanks for review. You are correct that CORBA was added in 1.2.
My understadning to those 1.0 to 1.1.6 versions are for override
methods, I guess the author is putting down the version of the origin.
There are several cases where @since can be ambiguous without a common
guideline,
- An method was private or package access only made public, should
@since denote the API availablity or the implementation?
- APIs from classed was extracted into a super class or interface in a
later version, what should be the @since?
- Implementation of interface methods
- Override methods
Guess they are actually all the same question, does @since mean API
availability or implementation?
For prior, interface/override methods should not carry it's own since,
for later, it should have @since as the owner class.
Cheers,
Henry
More information about the core-libs-dev
mailing list