RFR (JAXP): 8035577: Xerces Update: impl/xpath/regex/RangeToken.java

[huizhe wang]

On 3/6/2014 12:31 AM, Alan Bateman wrote:
> On 05/03/2014 22:17, huizhe wang wrote:
>>
>> On 3/5/2014 1:38 PM, Alan Bateman wrote:
>>> On 05/03/2014 20:18, David Li wrote:
>>>> Hi,
>>>>
>>>> This is an update from Xerces for file 
>>>> impl/xpath/regex/TokenRange.java.  For details, please refer to: 
>>>> https://bugs.openjdk.java.net/browse/JDK-8035577.
>>>>
>>>> Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035577/webrev/
>>>>
>>>> No new tests.  There were none added in Xerces.
>>>>
>>>> Existing tests: JAXP SQE and unit tests passed.
>>> Do you know if these tests exercise this code? I realize the Xerces 
>>> didn't come with tests but I do have a concern about changing regex 
>>> code without knowing that it is at least exercised by some tests.
>>
>> There are over 100 tests in SQE suite in this area, we'll take a look.
> If you can check then that would be good as I think I can be forgiven 
> for being nervous about bringing in patches that don't have tests.

Understand. We'll look into adding new tests.

-Joe

>
> -Alan.