RFR [6943190] TEST_BUG: java/lang/Runtime/exec/ExecWithInput.java hardcodes path to cat

Martin Buchholz martinrb at google.com
Wed Mar 19 16:23:46 UTC 2014


+        if (trueCmd == null) {
+            System.err.println("'true' not found");
             return;
+        }


I expected to see System.out used instead (not that it matters much).

I would write:

System.out.println("'true' command not found; skipping test");


On Wed, Mar 19, 2014 at 8:50 AM, Ivan Gerasimov
<ivan.gerasimov at oracle.com>wrote:

> Here's the (hopefully final) polished webrev: removed 'othervm' and
> replaced stderr with stdout in reporting of the wrong OS.
>
> Would you please take a look?
>
> http://cr.openjdk.java.net/~igerasim/6943190/4/webrev/
>
> Sincerely yours,
> Ivan
>
>



More information about the core-libs-dev mailing list