JDK 9 RFR of 6375303: Review use of caching in BigDecimal

[Peter Levart]

On 03/24/2014 06:48 PM, Brian Burkhalter wrote:
> Hi Peter,
>
> On Mar 24, 2014, at 2:21 AM, Peter Levart <peter.levart at gmail.com 
> <mailto:peter.levart at gmail.com>> wrote:
>
>> Thanks to Aleksey for re-establishing the access, I bring you results 
>> of the microbenchmark from his quad-core Cortex-A9:
>
> Thanks to you and Aleksey for taking the initiative to test on that 
> platform.
>
>> ...as can be seen, the double-checked read-then-volatile-read+CAS 
>> trick is about 15% faster than classic volatile-read+CAS in this case.
>
> Just to be sure, by “double-checked read-then-volaite-read+CAS trick” 
> you intend "the variant with two methods toString/toStringSlow?”

That's right. I split the code into two methods in both cases to make 
sure it gets inlined for fast-path. The variant in your webrev with 
single method has been demonstrated to exceed the maximum inline 
bytecode size.

Regards, Peter

>
> Thanks,
>
> Brian