RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

[Yekaterina Kantserova]

On 03/25/2014 01:14 PM, Staffan Larsen wrote:
> I’ve looked at a random sample of these changes and they look ok.
>
> Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
>
> I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
I would not. My thought was to be done with review process and be ready 
to push when JTreg is promoted.

Thank you for adding other groups!
Katja

>
> Thanks,
> /Staffan
>
> On 25 mar 2014, at 13:07, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
>
>> Hi,
>>
>> Could I please have a review of this fix.
>>
>> webrev: http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8034960
>>
>> When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
>>
>> Verified locally since no JTreg with fix has been promoted yet.
>>
>>
>> Thanks,
>> Katja