RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

[Igor Ignatyev]

Hi Chris,

> This is very nice.  Are there plans to do this for the other existing tests as well?
sure, but we didn't have enough time to do it in 8u20 timeframe. So I'd 
like to push these changes 1st, since we need this to cover 'Speedup 
catch exceptions'. Other tests will be rewrite later. I hope we'll have 
time in jdk 9 to refactor all tests in MethodHandles.

Thanks,
Igor

On 03/27/2014 12:38 AM, Christian Thalinger wrote:
>
> On Mar 24, 2014, at 1:33 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>
>> Hi all,
>>
>> Please review the patch:
>>
>> Problems:
>> - MethodHandlesTest::testCatchException() doesn't provide enough testing of j.l.i.MethodHandles::catchException().
>> - MethodHandlesTest contains more than 3k lines, an auxiliary code together w/ a test code, many methods aren't connected w/ each other, etc. All this leads to that it is very very hard to understand, maintain.
>
> Yes, it is.
>
>>
>> Fix:
>> - the auxiliary code was moved to testlibray
>> - the test code was moved to a separate subpackage
>
> This is very nice.  Are there plans to do this for the other existing tests as well?
>
>> - random signature is used for target and handler
>> - added scenarios w/ different return types
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev/8038186/webrev.01/
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8038186
>> --
>> Igor
>> _______________________________________________
>> mlvm-dev mailing list
>> mlvm-dev at openjdk.java.net
>> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
>
> _______________________________________________
> mlvm-dev mailing list
> mlvm-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
>