RFR: 8000975: (process) Merge UNIXProcess.java.bsd & UNIXProcess.java.linux (& .solaris & .aix)

[Volker Simonis]

Hi Peter,

thanks for applying these changes to the AIX files as well.

With the additional line:

            if (osName.equals("AIX")) { return AIX; }

in Os.get() your change compiles cleanly on AIX and runs the
java/lang/ProcessBuilder tests without any errors.

So from an AIX perspective, thumbs up.

Regards,
Volker


On Wed, Mar 26, 2014 at 5:18 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 26/03/2014 15:19, Peter Levart wrote:
>>
>> I couldn't find any official document about possible os.name values for
>> different supported OSes. Does anyone have a pointer?
>
> I don't know if there is a definite list but I assume we don't need to be
> concerned with anything beyond the 4 that we have in OpenJDK, which is
> "Linux", "SunOS", "AIX" and contains("OS X").
>
> If we get to the point in JDK 9 where src/solaris is renamed to src/unix (or
> something equivalent) then it could mean that the Os enum can be replaced
> with an OS specific class in src/linux, src/solaris, ... and this would
> avoid the need for an os.name check at runtime.
>
> -Alan.
>