RFR [8040806]: BitSet.toString() can throw IndexOutOfBoundsException

[Mike Duigou]

The fix looks good though I wonder if the conditional checks can be optimized a bit.

I am concerned that the suggested iteration method provided in the nextSetBit() javadoc induces the same failure we just corrected. Perhaps we should revise that advice?

Mike

On May 5 2014, at 09:56 , Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:

> Hello!
> 
> This is a friendly reminder.
> Could a Reviewer please review/approve this fix?
> 
> The problem is that a BitSet can have bit # MAX_VALUE set, but trying to convert it to String throws an exception.
> 
> Sincerely yours,
> Ivan
> 
> On 22.04.2014 16:13, Ivan Gerasimov wrote:
>> Hello!
>> 
>> If a BitSet has the bit Integer.MAX_VALUE set, then calling toString() will throw an exception.
>> The same thing happens if the bit (Integer.MAX_VALUE-1) is set.
>> 
>> Would you please help review the fix for this issue?
>> 
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8040806
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8040806/0/webrev/
>> 
>> Sincerely yours,
>> Ivan
>> 
>