RFR 9: 8003488 Add Process.getPid

Martin Buchholz martinrb at google.com
Tue May 27 16:57:10 UTC 2014


Looks good to me too (but I'm sure Alan did a more careful review than I).


On Tue, May 27, 2014 at 6:30 AM, Alan Bateman <Alan.Bateman at oracle.com>
wrote:

> On 22/05/2014 20:47, roger riggs wrote:
>
>> Thanks for the feedback and recommendations; the webrev has been updated.
>>
>> Webrev: http://cr.openjdk.java.net/~rriggs/webrev-getpid-8003488/
>>
>> Alan, on the use of tasklist, I think a cleaner test can be written when
>> the
>> Java API to inspect other processes is available.  I did not find a
>> straightforward
>> eqivalent for $$; there is a possible hack using tasklist but it would be
>> a throwaway.
>>
>> Roger
>>
>>  The updated webrev looks good to me. On tasklist then what you have is
> fine for now, it can always be re-visited if it gives trouble or there is
> an API available.
>
> -Alan.
>
>



More information about the core-libs-dev mailing list