[9] RFR (XXS): 8035186: j2se_jdk/jdk/test/java/lang/invoke/lambda/LogGeneratedClassesTest.java - assertion error

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Wed May 28 10:36:25 UTC 2014


Thanks, Paul.
I agree your comments and will address them before the push.

Best regards,
Vladimir Ivanov

On 5/28/14 2:04 PM, Paul Sandoz wrote:
>
> On May 27, 2014, at 6:16 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
>
>> Good catch!
>> One more iteration:
>> http://cr.openjdk.java.net/~vlivanov/8035186/webrev.02/
>>
>
> Looks good.
>
> Some minor points, no need for another review round either way:
>
> - don't need the nested try blocks in isWriteableDirectory, just tack the finally block on the end of the last catch block.
>
> - could add a println when there is no POSIX environment to indicate the test is not run and remove it when/if jtreg supports skipping.
>
> Paul.
>
>



More information about the core-libs-dev mailing list