Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

Otávio Gonçalves de Santana otaviojava at java.net
Sun Nov 2 14:45:59 UTC 2014


Could another reviewer look these codes, please.
http://cr.openjdk.java.net/~weijun/8055723/webrev.00/

On Fri, Oct 24, 2014 at 3:25 AM, Otávio Gonçalves de Santana <
otaviojava at java.net> wrote:

> Thank you Ulf.
> I removed the fix in toString method and in debug classes:
> http://cr.openjdk.java.net/~weijun/8055723/webrev.00/
>
> On Mon, Oct 20, 2014 at 10:26 PM, Ulf Zibis <Ulf.Zibis at cosoco.de> wrote:
>
>>
>> Am 21.10.2014 um 01:02 schrieb Otávio Gonçalves de Santana:
>>
>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8055723
>>>
>>>
>>> WEBREV: http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/
>>> WEBREV: http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/
>>>
>>
>> I did not look through all sources.
>> In Scanner.java I discovered:
>> 1307 sb.append("[delimiters=").append(delimPattern).append(']');
>> 1308         sb.append("[position=").append(position).append(']');
>> ...
>> Maybe better:
>> 1307         sb.append("[delimiters=").append(delimPattern);
>> 1308         sb.append("][position=").append(position);
>> ...
>>
>> -Ulf
>>
>>
>
>
> --
> Otávio Gonçalves de Santana
>
> blog:     http://otaviosantana.blogspot.com.br/
> twitter: http://twitter.com/otaviojava
> site:     *http://about.me/otaviojava <http://about.me/otaviojava>*
> 55 (11) 98255-3513
>



-- 
Otávio Gonçalves de Santana

blog:     http://otaviosantana.blogspot.com.br/
twitter: http://twitter.com/otaviojava
site:     *http://about.me/otaviojava <http://about.me/otaviojava>*
55 (11) 98255-3513



More information about the core-libs-dev mailing list