RFR: 8063147: Class.getFields spec should state that fields are inherited from superinterfaces

Chris Hegarty chris.hegarty at oracle.com
Mon Nov 10 10:40:04 UTC 2014


On 10/11/14 09:43, Paul Sandoz wrote:
> On Nov 6, 2014, at 8:07 PM, Martin Buchholz <martinrb at google.com> wrote:
>> Sorry, Paul, I missed your offer on the other thread to take this to
>> CCC.  It's yours.
>>
>> On Thu, Nov 6, 2014 at 10:50 AM, Martin Buchholz <martinrb at google.com> wrote:
>>> Hi Joe,
>>>
>>> I'd like you to do a code review.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8063147
>>> Webrev: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/Class-getFields-spec/

The change looks good to me.

>>> getFields was embarrassingly undertested, so I added some.
>>>
>
> Test looks good.

Yes, very nice.

>>> Please shepherd through CCC.
>
> Kick started.

Reviewed.

-Chris.

> Paul.
>



More information about the core-libs-dev mailing list