RFR 8047962: XML test colocation: AuctionPortal test for bid.com

[huizhe wang]

Hi Tristan,

Did you mean to keep the original code you replaced with nio, that is, 
the ones you commented out and the read method that's no longer used?

-Joe

On 11/11/2014 12:26 PM, Tristan Yan wrote:
> Hi Joe
> I changed movies.xml to a txt format for avoiding binary file is not 
> supported issue. Also I’ve added the BOM header support for txt file 
> in JAXPTestUtilities. Please see the latest webrev at 
> http://cr.openjdk.java.net/~tyan/JDK-8047962/webrev.04/ 
> <http://cr.openjdk.java.net/%7Etyan/JDK-8047962/webrev.04/>
> I appreciate you can push it if you’re okay with this change.
> Thank you
> Tristan
>
>> On Nov 5, 2014, at 4:01 PM, Tristan Yan <tristan.yan at oracle.com 
>> <mailto:tristan.yan at oracle.com>> wrote:
>>
>> Thanks again
>> This makes more sense to me. Now they look clearer.
>>
>> http://cr.openjdk.java.net/~tyan/JDK-8047962/webrev.03/ 
>> <http://cr.openjdk.java.net/%7Etyan/JDK-8047962/webrev.03/> 
>> <http://cr.openjdk.java.net/~tyan/JDK-8047962/webrev.03/ 
>> <http://cr.openjdk.java.net/%7Etyan/JDK-8047962/webrev.03/>>
>>
>> Thank you for sponsoring this.
>> Tristan
>>
>>> On Nov 5, 2014, at 3:23 PM, huizhe wang <huizhe.wang at oracle.com 
>>> <mailto:huizhe.wang at oracle.com>> wrote:
>>>
>>> Hi Tristan,
>>>
>>> It's good to see movie.xml is replaced with a literal string.
>>>
>>> Sorry if I wasn't clear on the directory structure. It would be nice 
>>> if all files for AuctionPortal to be placed under AuctionPortal, 
>>> that is:
>>> test/javax/xml/jaxp/functional/test/auctionportal/
>>>                                                 content/ (xml and xsd)
>>>                                                 golden/  (gold files)
>>>
>>>
>>> Would that make sense?  It's nice you have the paths in one place 
>>> (HiBidConstants) that makes it easier to move files around.
>>>
>>> Yes, I'll sponsor that for you.
>>>
>>> Thanks,
>>> Joe
>>>
>>> On 11/5/2014 2:57 PM, Tristan Yan wrote:
>>>> Thank you. Joe.
>>>> Git plugin for mercurial works well for hg command but webrev 
>>>> script still doesn’t support the binary file. I did one small 
>>>> change to replace movies.xml with a Java string to suppress this 
>>>> error. Also I took your advice to move xml files into auction 
>>>> portal directory. Changed tests have been run with and without the 
>>>> Security Manager as usual. All the tests pass under both scenarios.
>>>>
>>>> http://cr.openjdk.java.net/~tyan/JDK-8047962/webrev.02/ 
>>>> <http://cr.openjdk.java.net/%7Etyan/JDK-8047962/webrev.02/> 
>>>> <http://cr.openjdk.java.net/%7Etyan/JDK-8047962/webrev.02/>
>>>>
>>>> Could you please sponsor this for me.
>>>> Thank you very much.
>>>> Tristan
>>>>
>>>>> On Nov 3, 2014, at 3:55 PM, huizhe wang <huizhe.wang at oracle.com 
>>>>> <mailto:huizhe.wang at oracle.com> <mailto:huizhe.wang at oracle.com>> 
>>>>> wrote:
>>>>>
>>>>> Hi Tristan,
>>>>>
>>>>> Looks good overall. Once again, it's great to see that you've made 
>>>>> the tests a lot cleaner, getting rid of the old report system and etc.
>>>>>
>>>>> The only issue I see is with movies.xml. If I use patch to apply 
>>>>> your patch to my workspace, I get no movies.xml that in turn 
>>>>> causes AuctionController to fail. It's probably related how your 
>>>>> webrev was generated (note the error: Unexpected Error occurred 
>>>>> reading `diff -e /dev/null 
>>>>> new/test/javax/xml/jaxp/functional/test/content/movies.xml`: $?=0, 
>>>>> err= 1 ).  hg diff works fine generally, but not for changes in 
>>>>> binary files. Use the git option, "-git", can fix the problem. You 
>>>>> may see the following in your configuration:
>>>>>
>>>>> [diff]
>>>>> git = true
>>>>>
>>>>> Thanks,
>>>>> Joe
>>>>>
>>>>> On 10/31/2014 12:16 PM, Tristan Yan wrote:
>>>>>> Hi Joe, Alan and all others
>>>>>>
>>>>>> Would you please help reviewing these tests? The intent is moving 
>>>>>> some JAXP tests from closed to open. The associated bug number is
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8047962 
>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8047962>.
>>>>>>
>>>>>> These tests have been ran with and without the Security Manager. 
>>>>>> All the tests pass under both scenarios.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~tyan/JDK-8047962/webrev.01/ 
>>>>>> <http://cr.openjdk.java.net/%7Etyan/JDK-8047962/webrev.01/> 
>>>>>> <http://cr.openjdk.java.net/%7Etyan/JDK-8047962/webrev.01/>
>>>>>> Thank you.
>>>>>> Tristan
>>>>>
>>>>
>>>
>>
>