RFR: AARCH64: 8064594: Top-level JDK changes

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Nov 13 23:06:28 UTC 2014


Looks like the only comment we have is to change 2013 year to 2014 in 
the Copyright header in new files (and keep creation year from old file 
as Joe suggested).

I can do that trivial change and push these changes into aarch64 staging 
repo.

webrev: http://cr.openjdk.java.net/~aph/aarch64-JDK-8064594-1/

I included David's review from other thread to keep all reviews here:

On 11/12/14 8:28 PM, David Holmes wrote:
 > On 13/11/2014 10:04 AM, Dean Long wrote:
 >> And adding build-infra-dev and jdk9-dev wouldn't hurt either.
 >
 > Let's not get carried away for what is quite a trivial copying of
 > existing platform specific patterns :) build-dev (not build-infra-dev)
 > would be okay. jdk9-dev isn't needed if already on hotspot-dev,
 > build-dev and sound-dev.
 >
 > These changes seem quite trivially fine to me.
 >
 > David H.

Thanks,
Vladimir

On 11/13/14 11:00 AM, joe darcy wrote:
> FWIW, if I were creating a new file by first copying an old file, I
> would use a copyright range from the creation date of the old file to
> the current year.
>
> -Joe
>
> On 11/13/2014 1:45 AM, Andrew Haley wrote:
>> On 12/11/14 23:51, Christian Thalinger wrote:
>>> The new jvm.cfg files should only have a copyright year of 2014.
>> Why, exactly?  They have been around for a while.
>>
>> Andrew.
>>
>



More information about the core-libs-dev mailing list