RFR: 8065172: More core reflection final and volatile annotations

Paul Sandoz paul.sandoz at oracle.com
Mon Nov 24 10:55:29 UTC 2014


On Nov 20, 2014, at 4:33 PM, Peter Levart <peter.levart at gmail.com> wrote:

> Hi Martin,
> 
> On 11/19/2014 01:42 AM, Martin Buchholz wrote:
>> Hi Joe, Peter, Paul
>> 
>> This is the followup on thread safety I promised Peter.
> 
> Looks good.
> 

Same here.


> I made the WildcardTypeImpl.[upperBoundASTs, lowerBoundASTs] and TypeVariableImpl.boundASTs fields volatile in my version of patch (instead of final):
> 
> http://cr.openjdk.java.net/~plevart/jdk9-dev/GenericsReflectionRaces/webrev.01/
> 
> ...so that after the structure they point to has been parsed into bound types, they can be thrown away. The comments indicate that possibility already, but the implementor was afraid to do it because of possible races. I think I got it right here.
> 

I think so too.

Paul.



More information about the core-libs-dev mailing list