Library enhancement proposal for copying data from/to Reader/Writer InputStream/OutputStream

Patrick Reinhart patrick at reini.net
Thu Nov 27 17:40:12 UTC 2014


> Am 27.11.2014 um 17:57 schrieb Alan Bateman <Alan.Bateman at oracle.com>:
> 
> On 27/11/2014 15:56, Pavel Rappo wrote:
>> Patrick, as soon as I get feedback from Alan and Paul I'll merge these changes into the current version.
>> 
>> 1. I wonder if it makes sense to provide an additional method where client specifies CharBuffer to be used?
>> Moreover if the first argument is CharSequence then we don't even need a buffer:
>> 
> I would suggest starting out with the simple copy(source, target) and only add additional variants if there is strong need. In this case, is a variant that allows the intermediate buffer to be specified be something that would be widely used?
> 
> -Alan

In our codebase here we have variants of different buffer sizes, mostly there are some with smaller sizes than the default I took from the Files class. To have the copy function within the JDK instead using a separate library or have this code written over and over again is much more important to me.

-Patrick


More information about the core-libs-dev mailing list