RFR 8066188: BaseRowSet default value for escape processing is not correct

[Lance Andersen]

Hi all,

Attached is a trivial change to address the default value for escape processing for BaseRowSet.  This aligns with the javadocs now for BaseRowSet as well as the default for escape process per the JDBC spec and other RowSets.

This also uncovered a JCK bug which I have made the JCK team aware of.

The change is trivial and I have included the diff:


 hg diff
diff -r 62fe5a5e2bae src/java.sql.rowset/share/classes/javax/sql/rowset/BaseRowSet.java
--- a/src/java.sql.rowset/share/classes/javax/sql/rowset/BaseRowSet.java	Tue Nov 11 20:11:34 2014 +0000
+++ b/src/java.sql.rowset/share/classes/javax/sql/rowset/BaseRowSet.java	Fri Nov 28 12:54:05 2014 -0500
@@ -462,7 +462,7 @@
      * <code>false</code> that it is not. The default is <code>true</code>.
      * @serial
      */
-    private boolean escapeProcessing;
+    private boolean escapeProcessing = true;
 
     /**
      * A constant indicating the isolation level of the connection
diff -r 62fe5a5e2bae test/javax/sql/testng/test/rowset/BaseRowSetTests.java
--- a/test/javax/sql/testng/test/rowset/BaseRowSetTests.java	Tue Nov 11 20:11:34 2014 +0000
+++ b/test/javax/sql/testng/test/rowset/BaseRowSetTests.java	Fri Nov 28 12:54:05 2014 -0500
@@ -186,11 +186,11 @@
     }
 
     /*
-     * Validate that getEscapeProcessing() returns false by default
+     * Validate that getEscapeProcessing() returns true by default
      */
     @Test
     public void test08() throws Exception {
-        assertFalse(brs.getEscapeProcessing());
+        assertTrue(brs.getEscapeProcessing());
     }


Best,
Lance


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com