RFR: 8059767: FileHandler should allow 'long' limits and handle overflow of MeteredStream.written.

[Ivan Gerasimov]

Hi Daniel!

Would it make sense to make the old constructor FileHandler(String, 
*int*, int, boolean) call the new one, casting the limit to long?

Sincerely yours,
Ivan

On 07.10.2014 17:13, Daniel Fuchs wrote:
> Hi,
>
> Please find below a patch for:
>
> 8059767: FileHandler should allow 'long' limits and handle overflow
>          of MeteredStream.written.
> https://bugs.openjdk.java.net/browse/JDK-8059767
>
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8059767/webrev.00/
>
> This follows an issue reported on this list:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028280.html 
>
>
> The patch changes 'limit' from 'int' to 'long', fixes the
> handling of overflow, and adds a new constructor that allows
> to pass a long for 'limit'.
> It also makes it possible to specify a long value for 'limit'
> in the configuration.
>
> The test checks the handling of overflow by tweaking the
> internal of MeteredStream through reflection. Not ideal, but
> I couldn't find any other way.
>
> best regards,
>
> -- daniel
>
>