RFR: 8060132: Handlers configured on abstract nodes in logging.properties are not always properly closed

Stanimir Simeonoff stanimir at riflexo.com
Fri Oct 10 15:12:07 UTC 2014


Please disregard the remark about "count", as any exception would make the
use of the index variable incorrect.

Stanimir

On Fri, Oct 10, 2014 at 6:10 PM, Stanimir Simeonoff <stanimir at riflexo.com>
wrote:

> persistentLoggers should be cleared on reset(), imo.
>
> Also using "count" and then "for in" to loop over an array looks a bit
> ugly, should be just "for (int i=0; i<names.length; i++){ final String
> className = names[i];..}
> Calling the class name 'word' is weird as well. (I do understand that's
> not new but it's a good time to get it straight).
>
> Cheers
> Stanimir
>
>
> On Fri, Oct 10, 2014 at 5:51 PM, Daniel Fuchs <daniel.fuchs at oracle.com>
> wrote:
>
>> Hi,
>>
>> Please find below a possible fix for:
>>
>> 8060132: Handlers configured on abstract nodes in logging.properties are
>> not always properly closed
>> https://bugs.openjdk.java.net/browse/JDK-8060132
>>
>> webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8060132/webrev.00/
>>
>> Other options have been discussed in this other email thread:
>>
>> Subject: JDK-6774110 lock file is not deleted when child logger is used
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-
>> October/029038.html
>>
>> best regards,
>>
>> -- daniel
>>
>
>



More information about the core-libs-dev mailing list