RFR 8058855: Update java.util.zip tests to work with modular image

David Holmes david.holmes at oracle.com
Mon Oct 13 01:29:12 UTC 2014


On 9/10/2014 3:50 PM, Amy Lu wrote:
> On 10/9/14, 1:23 PM, David Holmes wrote:
>> Hi Amy,
>>
>> On 9/10/2014 3:15 PM, Amy Lu wrote:
>>> Two java/util/zip tests use JDK rt.jar in test, this fix is to remove
>>> this dependency from test because with a modular rt.jar and the other
>>> JAR files in the JDK go away.
>>>
>>> bug:    https://bugs.openjdk.java.net/browse/JDK-8058855
>>> webrev: http://cr.openjdk.java.net/~tyan/amylu/8058855/webrev.00/
>>
>> test/java/util/zip/InterruptibleZip.java
>>
>> Where is input.jar coming from?
>
> It's an existing jar file in test dir.

Is it copied-there/created-by some other part of the test?

>>
>> test/java/util/zip/ZipFile/FinalizeZipFile.java
>>
>> The File variable "lib" is no longer suitably named.
>
> Updated name "lib" to "testdir":
> http://cr.openjdk.java.net/~weijun/8058855/webrev.01/

Thanks,
David

> Thanks,
> Amy
>
>
>>
>> Cheers,
>> David
>>
>>> Thanks,
>>> Amy
>



More information about the core-libs-dev mailing list