RFR 8058856: tools/jar/LeadingGarbage.java, introduced in JDK-8058520, fails on Windows

Alan Bateman Alan.Bateman at oracle.com
Mon Oct 13 13:50:37 UTC 2014


On 13/10/2014 14:44, Amy Lu wrote:
> Please review the test fix.
>
> Test tools/jar/LeadingGarbage.java fails on Windows, wrong line 
> separator used. Also fixed resource unclosed issue.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8058856
> webrev: http://cr.openjdk.java.net/~weijun/8058856/webrev.00/
This looks okay to me. An alternative for createZipWithLeadingGarbage is 
to just use Files.copy(normalZip.toPath(), leadingGarbageZip.toPath()).

-Alan.



More information about the core-libs-dev mailing list