Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

Tristan Yan tristan.yan at oracle.com
Tue Oct 14 21:57:27 UTC 2014


Hi Joe
If you’re okay with the code; would you be my sponsor for this. We need move forward and push these tests into openjdk repo.
Thank you so much
Tristan

> On Aug 29, 2014, at 11:21 AM, huizhe wang <huizhe.wang at oracle.com> wrote:
> 
> Hi Tristan,
> 
> Looks good. I left notes in the bug's comment section as a record and status of the original test development.
> 
> Thanks,
> Joe
> 
> On 8/29/2014 9:50 AM, Tristan Yan wrote:
>> Hi Joe, Alan and others
>> I took over Eric’s last work and did some refactor for his code. Please help to review the code change again. 
>> webrev: http://cr.openjdk.java.net/~tyan/JDK-8051561/webrev.01/ <http://cr.openjdk.java.net/%7Etyan/JDK-8051561/webrev.01/>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8051561 <https://bugs.openjdk.java.net/browse/JDK-8051561>
>> 
>> These code has been run with security manager and without security manager both and all passed.
>> Thank you
>> Tristan
>> 
>>> On Jul 25, 2014, at 6:12 AM, Eric Wang <yiming.wang at oracle.com <mailto:yiming.wang at oracle.com>> wrote:
>>> 
>>> Hi Joe, alan and every one
>>> 
>>> I'm working on jaxp functional test colocation which is traced by the bug JDK-8043091 <https://bugs.openjdk.java.net/browse/JDK-8043091>.
>>> We have finished to convert a few suite and the jaxp/xpath tracked by bug JDK-8051561 <https://bugs.openjdk.java.net/browse/JDK-8051561> is the first one chosen for public review.
>>> 
>>> Can you please review the webrev below? your comments given would be helpful for our future work.
>>> http://cr.openjdk.java.net/~ewang/JDK-8051561/webrev.00/ <http://cr.openjdk.java.net/%7Eewang/JDK-8051561/webrev.00/>
>>> 
>>> Thanks,
>>> Eric
>>> 
>> 
> 




More information about the core-libs-dev mailing list