Request for review/advice from langtools team<was> Re: Covariant overrides on the Buffer Hierarchy redux

Paul Sandoz paul.sandoz at oracle.com
Mon Oct 27 09:12:11 UTC 2014


Hi,

Can someone from langtools kindly chime in with how to move this forward?

  https://bugs.openjdk.java.net/browse/JDK-4774077

  http://cr.openjdk.java.net/~rwarburton/buffer-overrides-3/

  http://cr.openjdk.java.net/~rwarburton/buffer-overrides-langtools-0/langtools.patch


On Oct 17, 2014, at 11:37 AM, Paul Sandoz <Paul.Sandoz at oracle.com> wrote:

> Hi,
> 
> [Including compiler-dev, i am not on that list so please CC me if replying to just that list]
> 
> 
...


> So Richard has a patch for that too:
> 
>   http://cr.openjdk.java.net/~rwarburton/buffer-overrides-langtools-0/langtools.patch
> 
> This is required because in the bootstrap compilation phase a JDK without the co-variant overrides can be used. So the current solution is to suppress the warnings. Reviews from langtools gurus are very much appreciated.
> 

?


> Ideally it would be nice to push all this under one issue, is that possible? If not i will have to create another issue and of course push to langtools before jdk.
> 
> A internal CCC is also underway.
> 

This has be approved, with the comment that "@since 1.9" should be added to the doc of the new methods, which i have done in my copy of the patch.

Thanks,
Paul.



More information about the core-libs-dev mailing list