RFR 7156085: ArrayIndexOutOfBoundsException throws in UTF8Reader of SAXParser

[huizhe wang]

On 10/29/2014 3:59 PM, Martin Buchholz wrote:
>
>
> On Wed, Oct 29, 2014 at 2:37 PM, huizhe wang <huizhe.wang at oracle.com 
> <mailto:huizhe.wang at oracle.com>> wrote:
>
>     Hi Martin,
>
>     You're welcome in the jaxp land :-)   Bandaid is what we need for
>     now. There are many things we would like to do to this aging code
>     base, unfortunately, we have to focus on a few.
>
>     The change looks okay. I did a full-test run and saw no failures.
>
>     One thing to note is that the SQE team has been working on
>     migrating jaxp unit and functional tests into the jaxp repo.
>     Before that's done, we should continue putting unit tests in
>     jdk/test. I've moved your test to jdk/test and also removed a few
>     unused imports.
>
>     http://cr.openjdk.java.net/~joehw/jdk9/7156085/webrev/
>     <http://cr.openjdk.java.net/%7Ejoehw/jdk9/7156085/webrev/>
>
>
> Your re-shuffling of files in your webrev looks fine. Feel free to 
> commit this change, (or I can do it)

Please do.

>     I saw that you included a license header in the test that had a
>     structure like: Google copyright + GNU GPL. I saw that you've
>     already done it before (e.g. JDK-8058520). I don't have a problem
>     with the lic header itself. But I'd like to know that the License
>     Structure was approved by legal. Has it been approved?
>
>
> yes, this is what new files contributed by Google have looked like for 
> many years.

Awesome!

Thanks,
Joe