RFR: 8043306 - Provide a replacement for the API that allowed to listen for LogManager configuration changes

[Alan Bateman]

On 10/09/2014 10:49, Daniel Fuchs wrote:
> Hi,
>
> Please find below a proposed patch for
>
> 8043306 - Provide a replacement for the API that allowed to listen
>           for LogManager configuration changes
> https://bugs.openjdk.java.net/browse/JDK-8043306
>
> Proposed Patch:
> http://cr.openjdk.java.net/~dfuchs/webrev_8043306/webrev.00/
>
It would be nice if ConfigurationListener could be an interface. I 
realize this might mean looking again at the security concerns in this 
area again to see if we could get away without requiring a construction 
time permission check. Clearly if it could be an interface then it begs 
the question as to why it's just not a Runnable but that probably means 
yet more effort to figure out the right security and whether the access 
control context should be recorded when registering.

Assuming ConfigurationListener remains as an abstract class then the 
no-arg constructor will need a one-line javadoc comment.

A small suggestion for addConfigurationListener to return LogManager to 
facilitate method invocation chaining when configuring the LogManager. 
It could be done for remove too but that is probably less interesting.

Another comment on addConfigurationListener is that about the wording 
"re-read and the configuration is changed". I think the configuration 
listeners are invoked when ever the configuration is read even if there 
aren't any changes.

The javadoc links in the readConfiguration methods make the line length 
a bit inconsistent with the existing javadoc, maybe the package name 
could be just dropped from the links or the link moved to the next line.

-Alan.