RFR (S) 8057936: java.net.URLClassLoader.findClass uses exceptions in control flow

Chris Hegarty chris.hegarty at oracle.com
Thu Sep 11 08:43:54 UTC 2014


On 10 Sep 2014, at 16:04, Claes Redestad <claes.redestad at oracle.com> wrote:

> On 09/10/2014 04:38 PM, mark.reinhold at oracle.com wrote:
>>> New webrev: http://cr.openjdk.java.net/~redestad/8057936/webrev.4/
>> Looks fine, but when an exception declaration is on its own line then
>> the opening brace of the method should be on its own line too, as in
>> the original:
>> 
>>     protected Class<?> findClass(final String name)
>>         throws ClassNotFoundException
>>     {
> 
> Original had weird 5 space indentation though:
> 
> http://cr.openjdk.java.net/~redestad/8057936/webrev.6/

This latest version looks good.

-Chris.

> 
> Will need a sponsor for this, if it looks good to everyone.
> 
> /Claes
> 
>> 
>> - Mark
> 




More information about the core-libs-dev mailing list