RFR: 8043306 - Provide a replacement for the API that allowed to listen for LogManager configuration changes

Daniel Fuchs daniel.fuchs at oracle.com
Fri Sep 12 14:59:03 UTC 2014


On 9/12/14 4:42 PM, Alan Bateman wrote:
> On 12/09/2014 15:16, Daniel Fuchs wrote:
>> Thanks Alan!
>>
>> I have updated the webrev with your suggestions:
>>
>> http://cr.openjdk.java.net/~dfuchs/webrev_8043306/webrev.04/
>>
>> -- daniel
>>
> A minor suggestion for readConfiguration is that "Any register
> configuration listeners .." might be a bit better than "The
> configuration listeners ...".
>
> In addConfigurationListener there is a <br> between the two sentences
> that talk about exceptions, I don't know if you intended that.

Done. I regenerated the webrev in place.
http://cr.openjdk.java.net/~dfuchs/webrev_8043306/webrev.04/

-- daniel
>
> Otherwise the javadoc looks good to me.
>
> -Alan.




More information about the core-libs-dev mailing list