RFR: 8058520: jar xf does not work on zip files with leading garbage.

[Martin Buchholz]

[image: Read zip files from the beginning? Read zip files from the end?
(both)]

On Tue, Sep 16, 2014 at 9:03 AM, Xueming Shen <xueming.shen at oracle.com>
wrote:

> On 9/15/14 6:40 PM, Martin Buchholz wrote:
>
>> Hi Alan, Xueming,
>>
>> I'd like you to do a code review.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8058520
>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jar-leadingGarbage/ <
>> http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/jar-leadingGarbage/
>> >
>>
>
>
> It was the performance concern back then that led us to keep using the
> input stream
> for extracting, if it's to extract the whole zip/jar.
>
> There is also some "regressions" reported later with the ZipFile path when
> dealing with
> some "wrong"/non-ZIP64-spec-compliant huge zip file, in which it's fine
> to access those
> entries from the beginning of the stream, but can't jump back to the
> individual entries
> from the cen table.
>
> It appears you will have to flip a coin to see which case is more
> "important"?
>
> -Sherman
>