[9] RFR: 8038966 JAX-WS handles wrongly xsd:any arguments for Web services

[Miroslav Kos]

Ok then, the webrev updated:
http://cr.openjdk.java.net/~mkos/8038966/jdk.03/
http://cr.openjdk.java.net/~mkos/8038966/jaxws.00/

btw. I had to tweak the path - using simply Paths.get("org") we get
     JTwork/scratch/org
but needed path is
     JTwork/classes/javax/xml/ws/xsanymixed/org
(classes instead of scratch + test path as prefix), so I changed the 
code to
         Path p = Paths.get("..", "classes", "javax", "xml", "ws", 
"xsanymixed", "org");

Thanks
Miran


On 18/09/14 14:01, Seán Coffey wrote:
> jtreg should remove the work/scratch directory upon test completion 
> but it's best practice to attempt to clean up generated files. No harm 
> there I think. Also needed in cases where test might be run manually. 
> I'd suggest keeping the clean up code in the testcase.
>
> regards,
> Sean.
>
> On 18/09/2014 12:29, Miroslav Kos wrote:
>> Oops, I missed that, thanks. One question yet - does it make sense 
>> any more to clean generated files now, when the location was changed? 
>> I think clean up should be done automatically by jtreg now, shouldn't 
>> it? If you agree, I would delete the method instead.
>>
>> Thanks
>> Miran
>>
>> On 18/09/14 11:49, Seán Coffey wrote:
>>>
>>> On 18/09/2014 10:12, Miroslav Kos wrote:
>>>> Thanks, Sean, good catch ...
>>>>
>>>> I changed the destination for generated files:
>>>> http://cr.openjdk.java.net/~mkos/8038966/jdk.02/
>>>>
>>>> Regarding usage ProcessBuilder instead of shell script - the 
>>>> problem is, that to compile test classes, wsdl must be compiled 
>>>> first - shell script is setup required before javac. The test would 
>>>> have to be run in two phases - first compiling+running java classes 
>>>> that compile wsdl (ProcessBuilder) and after that compiling other 
>>>> java classes using result of previous run.
>>>>
>>>> I was solving this with jtreg some time ago already, but I haven't 
>>>> found other way than using shell script. If you know better 
>>>> solution, it would be great ...
>>> Ah - I see the dependency now. Thanks for the information.
>>>
>>> Just spotted one other issue. The deleteGeneratedFiles() method 
>>> scans for files in the
>>> test src path (for deletion) - No files should be created there now. 
>>> You can change that
>>> to scan the test classes path now. You could just use the current 
>>> working directory I guess
>>> since that's where jtreg will generate the new files.
>>>
>>> Paths.get("org");
>>>
>>> once that's fixed up, I can run this through JPRT and it should be 
>>> good to push then.
>>>
>>> regards,
>>> Sean.
>>>
>>>>
>>>> Thanks
>>>> Miran
>>>>
>>>>
>>>>
>>>> On 17/09/14 16:16, Seán Coffey wrote:
>>>>> Miran,
>>>>>
>>>>> the src change looks ok but I think there's a problem with the 
>>>>> testcase.
>>>>>
>>>>> You've defined generated classes for wsimport to be output to the 
>>>>> TESTSRC
>>>>> directory. This is often read only and won't work.
>>>>>
>>>>> TESTCLASSES is the variable you're probably looking for. In any 
>>>>> case, I think
>>>>> it's possible for you to avoid use of scripting. Can you invoke 
>>>>> wsimport via
>>>>> the ProcessBuilder API like that done for other wsimport tests ?
>>>>>
>>>>> regards,
>>>>> Sean.
>>>>>
>>>>> On 17/09/14 14:00, Miroslav Kos wrote:
>>>>>> Hi everybody,
>>>>>>
>>>>>> please review patch fixing following issue:
>>>>>>
>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8038966
>>>>>> webrev:
>>>>>> http://cr.openjdk.java.net/~mkos/8038966/jaxws.00/
>>>>>> http://cr.openjdk.java.net/~mkos/8038966/jdk.01/
>>>>>>
>>>>>> It is second part of fix ensuring that content of type 
>>>>>> xsd:any/content=mixed stays unchanged when processed with JAX-B 
>>>>>> RI. Regression test within webrev.
>>>>>>
>>>>>> Sean, could you sponsor it for me?
>>>>>>
>>>>>> Thanks
>>>>>> Miran
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>