RFR: 8059411, RowSetWarning does not chain warnings

Mandy Chung mandy.chung at oracle.com
Mon Sep 29 23:18:06 UTC 2014


About the rwarning field, if it's removed, would it break anything if 
it's filled with the default value when deserializing the new version on 
an older version?  It seems okay for this case and you should verify.

Otherwise, looks okay.

Mandy

On 9/29/14 3:08 PM, Lance Andersen wrote:
> Thank you Mandy
>
> I made the change you suggested
>
> http://cr.openjdk.java.net/~lancea/8059411/webrev.01/ 
> <http://cr.openjdk.java.net/%7Elancea/8059411/webrev.01/>
>
> and verified all is still good as expected with the tests.
>
> Best
> Lance
> On Sep 29, 2014, at 5:48 PM, Mandy Chung <mandy.chung at oracle.com 
> <mailto:mandy.chung at oracle.com>> wrote:
>
>> On 9/29/14 2:21 PM, Lance Andersen wrote:
>>> Hi all,
>>>
>>>
>>> Need a reviewer for 8059411 which is a simple fix & test for the 
>>> fact RowSetWarning does not properly chain warnings.    With the 
>>> fix, the JCK still passes.
>>>
>>> The webrev can be found at 
>>> http://cr.openjdk.java.net/~lancea/8059411/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Elancea/8059411/webrev.00/>
>>
>> Looks ok.
>>
>> line 132: an alternative for the type casting is:
>>     RowSetWarning.class.cast(getNextException());
>>
>> Mandy
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>




More information about the core-libs-dev mailing list