Review request for JDK-8051559: JAXP function dom tests conversion

[huizhe wang]

Hi Frank,

I did see the request, just didn't have time to look at it.

I again agree with Lance, that these tests were written over 10 years 
ago, it would be valuable to write down whatever understanding you 
gained while converting the tests, same as the Astro application/test, 
the goal of each test and how it works would all be helpful. Basically, 
it would be nice to add some comment on @Test.

I tried the tests. They worked fine with my current build (with some 
changes).

Thanks,
Joe

On 3/31/2015 7:10 AM, Lance Andersen wrote:
> Hi Frank
> On Mar 31, 2015, at 7:24 AM, Lance @ Oracle <lance.andersen at oracle.com 
> <mailto:lance.andersen at oracle.com>> wrote:
>
>> Hi frank
>>
>> Can you forward the other review request as I think I thought they 
>> were the same and deleted it
>
> Ignore this comment, the subjects were too similar but this is what 
> needed reviewed.
>>
>> I will look at this again today
>
> The tests overall look fine.
>
> I still have the same comment WRT providing a simple comment 
> describing each test.  The key point to remember is we want to make it 
> easier for someone to  look at the test, understand what you are 
> trying to validate, and understand the coverage of the tests.  This 
> will help future maintainers of the code.  Comments are just as 
> important in test code as it is in implementation IMHO.
>
> Best
> Lance
>>
>> Best
>> Lance
>>
>>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>> Andersen| Principal Member of Technical Staff | +1.781.442.2037 
>> <tel:+1.781.442.2037>
>> Oracle Java Engineering
>> 1 Network Drive <x-apple-data-detectors://34/0>
>> Burlington, MA 01803 <x-apple-data-detectors://34/0>
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> Sent from my iPad
>>
>> On Mar 31, 2015, at 4:15 AM, Frank Yuan <frank.yuan at oracle.com 
>> <mailto:frank.yuan at oracle.com>> wrote:
>>
>>> Hi Joe
>>>
>>>
>>>
>>> Do you have any comment for dom suite co-location?
>>>
>>>
>>>
>>> Best Regards
>>>
>>> Frank
>>>
>>>
>>>
>>> From: Frank Yuan [mailto:frank.yuan at oracle.com]
>>> Sent: Wednesday, March 25, 2015 5:46 PM
>>> To: 'huizhe wang'; 'Core-Libs-Dev'
>>> Cc: 'jibing chen'; 'Gustavo Galimberti'; sandeep.konchady at oracle.com 
>>> <mailto:sandeep.konchady at oracle.com>;
>>> 'Alexandre (Shura) Iline'
>>> Subject: RE: Review request for JDK-8051559: JAXP function dom tests
>>> conversion
>>>
>>>
>>>
>>> Hi, Joe and All
>>>
>>>
>>>
>>> We are working on moving internal jaxp functional tests to open jdk 
>>> repo.
>>>
>>> This is the dom suite. Would you please review these test?  Any 
>>> comment will
>>> be appreciated.
>>>
>>>
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8051559
>>>
>>> webrev: http://cr.openjdk.java.net/~fyuan/8051559/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Efyuan/8051559/webrev.00/>
>>>
>>>
>>>
>>> Thanks,
>>>
>>>
>>>
>>> Frank
>>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>