Code review request for JDK-8076441: Remove dead code in java.time.chrono.Chronology.isLeapYear

Ivan Gerasimov ivan.gerasimov at oracle.com
Thu Apr 2 14:24:41 UTC 2015


Looks good.

Can we also fix a typo in the doc with this change?

662      * Return the maximum supported Hijrah ear.


s/ear/year/   :)

Sincerely yours,
Ivan

On 01.04.2015 22:50, nadeesh tv wrote:
> Hi all,
>
> Please review this minor change which remove a dead code in 
> isLeapYear(long prolepticYear) method of 
> java/time/chrono/HijrahChronology.java.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8076441
> Webrev: http://cr.openjdk.java.net/~rriggs/hadeesh-tv-8076441/
>




More information about the core-libs-dev mailing list