RFR JDK-8076641: getNextEntry throws ArrayIndexOutOfBoundsException when unzipping file

Alan Bateman Alan.Bateman at oracle.com
Sat Apr 4 07:48:41 UTC 2015


On 03/04/2015 23:24, Xueming Shen wrote:
> Hi,
>
> Please help review the changeset for
>
> issue: https://bugs.openjdk.java.net/browse/JDK-8076641
> webrev: http://cr.openjdk.java.net/~sherman/8076641/webrev/
>
> It appears there is zip tool over there that purposely doesn't 
> generate the complete
> NTFS timestamp in loc table (while it does generate the correct one in 
> cen header),
> probably to save some bytes.
>
> The proposed change here is to simply ignore those "data blocks" 
> during extra data
> parsing, if no enough valid data embedded.
This looks okay to me although it does seems a bit odd to have an NTFS 
extra field here without the attributes that are defined for this tag. I 
don't see it it in the bug to know which zip tool this is.

-Alan



More information about the core-libs-dev mailing list