Review Request for 8039440: Tidy warnings cleanup for org/omg

[Lance Andersen]

Hi Alexander,

InTypeCode.java you might want to use {@code} vs <code> so that you do not have to use > < 

Otherwise it is OK

Best
Lance
On Apr 7, 2015, at 1:00 PM, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:

> Hello Roger,
> 
> Thank you for the notes, fixed:
> http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/src/java.corba/share/classes/org/omg/CORBA/portable/package.html.udiff.html
> http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/src/java.corba/share/classes/org/omg/CORBA/ShortHolder.java.udiff.html
> http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/src/java.corba/share/classes/org/omg/CORBA/TypeCode.java.udiff.html
> 
> Regards,
> Alexander
> 
> On 07.04.2015 18:20, Roger Riggs wrote:
>> Hi,
>> 
>> Just a few minor comments;  no need for another webrev (on my account).
>> 
>> The preferred form for code markup is {@code } instead of <code>... </code>
>> and <tt>... </tt> but that may beyond the scope of the current issue.
>> 
>> - Lowercase markup <p> is preferred over uppercase <P> but per file conventions should be consistent.
>> 
>> +++ new/src/java.corba/share/classes/org/omg/CORBA/portable/package.html 2015-04-07 16:41:12.299150361 +0400
>> 
>> -<li>Delegate
>> +<li><*code*>Delegate</*code*>
>> 
>> (RR) Why is this list element in code, the others are not.
>> 
>> +++ new/src/java.corba/share/classes/org/omg/CORBA/ShortHolder.java 2015-04-07 16:41:09.883150470 +0400
>> @@ -32,7 +32,7 @@
>> /**
>>  * The Holder for <tt>Short</tt>.  For more information on
>>  * Holder files, see <a href="doc-files/generatedfiles.html#holder">
>> - * "Generated Files: Holder Files"</a>.<P
>> + * "Generated Files: Holder Files"</a>.*<P>*
>> 
>> (RR) <p> should be on a new line; before the paragraph it separates
>> 
>> +++ new/src/java.corba/share/classes/org/omg/CORBA/TypeCode.java 2015-04-07 16:41:10.567150439 +0400
>> 
>> @@ -164,9 +164,9 @@
>>  *
>>  * Java IDL extends the CORBA specification to allow all operations permitted
>>  * on a <code>struct</code> <code>TypeCode</code> to be permitted
>> - * on an <code>exception</code> <code>TypeCode</code> as well. <p>
>> - *
>> + * on an <code>exception</code> <code>TypeCode</code> as well.
>>  */
>> +
>> public abstract class TypeCode implements IDLEntity {
>> 
>> (RR) There should not be blank line between comment and class definition.
>> 
>> 
>> Thanks, Roger
>> 
>> 
>> On 4/7/2015 10:40 AM, alexander stepanov wrote:
>>> Hello,
>>> 
>>> I'm not if the mail list is correct, but could anyone please review the following fix?
>>> http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8039440
>>> 
>>> Just an HTML markup fix for CORBA.
>>> 
>>> Thanks,
>>> Alexander
>>> 
>> 
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com