RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException

David Holmes david.holmes at oracle.com
Tue Apr 14 00:55:55 UTC 2015


On 14/04/2015 8:49 AM, Brent Christian wrote:
> Hello,
>
> Please review this small javadoc change.
>
> It was discovered that some codePoint-related methods in StringBuffer
> are missing documentation for throwing IndexOutOfBoundsException.  The
> methods are:
>
>    codePointAt(int)
>    codePointBefore(int)
>    codePointCount(int,int)
>    offsetByCodePoints(int,int)
>
> The StringBuilder JavaDoc does have @throws tags for those methods.

Not that you need another review but Reviewed :)

I really just wanted to add that I'm surprised that after all this time 
of having to deal with the complexity of javadoc inheritance rules, that 
we don't have anything to assist with detecting these omissions, as it 
is so easy to forget to redeclare unchecked exceptions. :(

David

> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8048264
> Webrev+specdiff:
> http://cr.openjdk.java.net/~bchristi/8048264/webrev.0/
>
> Thanks,
> -Brent



More information about the core-libs-dev mailing list