[9] RFR of 8075156: (prefs) remove() should disallow the use of the null control character '\u0000' as key

Brian Burkhalter brian.burkhalter at oracle.com
Wed Apr 15 17:08:27 UTC 2015


Hi Roger,

On Apr 15, 2015, at 9:50 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:

> Looks fine as is.

Thanks for reviewing it.

> But I'm curious why CODE_POINT_U000 is defined as  String instead of char?
> The indexOf() operation is more efficient for single characters.

Probably because I had initially used contains(CharSequence) instead of indexOf(String) and when I changed the former to the latter I did not change the constant. I will modify this per your suggestion.

Thanks,

Brian


More information about the core-libs-dev mailing list